Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helix mesh defects #647

Closed
phkahler opened this issue Jul 11, 2020 · 0 comments · Fixed by #648
Closed

Helix mesh defects #647

phkahler opened this issue Jul 11, 2020 · 0 comments · Fixed by #648
Assignees
Labels

Comments

@phkahler
Copy link
Member

System information

SolveSpace version:

Operating system: All

Expected behavior

Make a helical extrusion from a rectangle and look at the triangle mesh.

Actual behavior

For meshes over 90 degrees there are periodic defects in the triangle mesh and at the ends.

Additional information

These defect appear because edges (trim curves) are broken into PWL segments independent of the surface. Straight lines have no need to be broken up as they lie perfectly on the surface. We should use the same subdivision algorithm as grid triangulation when doing a helical extrusion of a straight edge.

This helix is over 90 degrees, so is composed of 2 section. The seam is clearly visible.
helix_defect

@phkahler phkahler self-assigned this Jul 11, 2020
@phkahler phkahler added the mesh label Jul 11, 2020
phkahler added a commit to phkahler/solvespace that referenced this issue Jul 12, 2020
Use the grid spacing algorithm for helical curve PWL creation.
This makes the grid and trim curves have similar spacing.
@phkahler phkahler linked a pull request Jul 12, 2020 that will close this issue
phkahler added a commit that referenced this issue Jul 12, 2020
Use the grid spacing algorithm for helical curve PWL creation.
This makes the grid and trim curves have similar spacing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant