Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

liburing: fix cross compilation #92887

Closed
wants to merge 1 commit into from
Closed

liburing: fix cross compilation #92887

wants to merge 1 commit into from

Conversation

expipiplus1
Copy link
Contributor

see #91079

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1 expipiplus1 mentioned this pull request Jul 10, 2020
Closed
9 tasks
@ofborg ofborg bot requested a review from thoughtpolice July 10, 2020 18:26
@flokli
Copy link
Contributor

flokli commented Jul 11, 2020

I am already able to build pkgsCross.armv7l-hf-multiplatform.liburing and pkgsCross.aarch64-multiplatform.liburing on master - possibly due to 57a5367 already on master.

@flokli flokli closed this Jul 11, 2020
@expipiplus1
Copy link
Contributor Author

Ah good to know!

@expipiplus1 expipiplus1 deleted the joe-uring-2 branch October 15, 2020 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@expipiplus1 @flokli