Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnomeExtensions.system-monitor: unbreak with newer GNOME Shell #92886

Merged
merged 2 commits into from Jul 10, 2020
Merged

gnomeExtensions.system-monitor: unbreak with newer GNOME Shell #92886

merged 2 commits into from Jul 10, 2020

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jul 10, 2020 •
edited

Motivation for this change

https://discourse.nixos.org/t/installing-gnome-system-monitor/8057

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested running GNOME Shell 3.36 with the extension (the applet appears in the panel)
  • Opened the extension's preferences and tweaked some settings successfully
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jtojnar
gnome3.mutter: export libdir
a100503 
It is needed for finding clutter & co. typelibs by extenstions.
@jtojnar
gnomeExtensions.system-monitor: unbreak with newer GNOME Shell
e96bf89 
Had to switch to master and include Clutter typelib to path since recent versions of GNOME Shell open preferences out of Shell context.
@jtojnar jtojnar mentioned this pull request Jul 10, 2020
Open
@jtojnar jtojnar requested review from tiramiseb, bjornfor and worldofpeace and removed request for tiramiseb and bjornfor July 10, 2020 18:19
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Jul 10, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/installing-gnome-system-monitor/8057/4

bjornfor
bjornfor approved these changes Jul 10, 2020
View reviewed changes
Copy link
Contributor

@bjornfor bjornfor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jtojnar jtojnar merged commit a23cb68 into NixOS:master Jul 10, 2020
@jtojnar jtojnar deleted the fix/gse-sysmon branch July 10, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@tiramiseb tiramiseb Awaiting requested review from tiramiseb

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jtojnar @nixos-discourse @bjornfor