Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python2Packages.numpy: fix build on darwin #92968

Merged
merged 1 commit into from Jul 13, 2020
Merged

python2Packages.numpy: fix build on darwin #92968

merged 1 commit into from Jul 13, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Jul 11, 2020 •
edited

By applying the old patch (compatible with 1.18.x and older). Also
refactor expression to make presence of the "old" version more
explicit.

Motivation for this change

To fix python2Packages in staging next (for #91090)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl mentioned this pull request Jul 11, 2020
Merged
10 tasks
@veprbl
Copy link
Member Author

veprbl commented Jul 12, 2020

@GrahamcOfBorg build python2Packages.numpy

@FRidh
Copy link
Member

FRidh commented Jul 12, 2020

please move numpy for python 2 into a separate expression instead.

@veprbl
python2Packages.numpy: fix build on darwin
1e4290b 
By applying the old patch (compatible with 1.18.x and older). Also
refactor expression to make presence of the "old" version more
explicit.
@veprbl
Copy link
Member Author

veprbl commented Jul 13, 2020

@GrahamcOfBorg build python2Packages.numpy

@vcunat vcunat merged commit 1e4290b into NixOS:staging-next Jul 13, 2020
@veprbl veprbl deleted the pr/py2_numpy_darwin_fix branch December 1, 2020 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@veprbl @FRidh @vcunat