Revert "bashCompletion: speed-up test execution by using xdist" #92915
+1
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a85b07c as executing the tests in parallel makes them flaky. This can be seen very easily on armv7l machines (and probably other machines that are slower than common x86_64 machines as well), but is also reproducible on x86_64. This fixes NixOS#91706.
KamilaBorowska
approved these changes
Jul 11, 2020
|
@Patagonicus can you drop upstream a note? |
|
Done: scop/bash-completion#430 |
|
Thanks! |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a85b07c as
executing the tests in parallel makes them flaky. This can be seen very
easily on armv7l machines (and probably other machines that are slower
than common x86_64 machines as well), but is also reproducible on
x86_64.
This fixes #91706.
Motivation for this change
These tests break very easily on armv7l and sometimes break on x86_64 as well if ran in parallel. I've not managed to get a single run to fail where the tests were executed serially.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)