Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump Roon-Server to latest version and fix bug #92945

Closed
wants to merge 1 commit into from
Closed

Bump Roon-Server to latest version and fix bug #92945

wants to merge 1 commit into from

Conversation

eljojo
Copy link

@eljojo eljojo commented Jul 11, 2020 •
edited

Motivation for this change

Update to the newest Roon version and fix bug with ZLib.

The newest version of Roon won't work without zlib. It took me a while to figure this out and truth being told I'm not fully sure this is the best way of going about it.

I run this at home and it works fine, but I'd prefer adding the appropriate zlib into a PATH somehow, instead of making symbolic links. Will this even survive garbage collection?

Can Mono's DLL mapping be used somehow?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@eljojo
Copy link
Author

eljojo commented Jul 11, 2020 •
edited

cc @Steell @infinisil @lovek323 you might find this useful

@eljojo
roon-server: 100600401 -> 100700571
2152104 
Mono was removed, since Roon ships its own.
Zlib was added, since the newest version seems to need it.
More context: https://community.roonlabs.com/t/roon-core-build-571-wont-boot-on-nixos-vm-linux/111217
@lovesegfault lovesegfault requested a review from vcunat July 22, 2020 02:32
lovesegfault
lovesegfault approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me!

@lovesegfault
Copy link
Member

Also: this can use ffmpeg instead of ffmpeg_3.

@lovesegfault
Copy link
Member

Also: RAATServer seems to not be able to find ALSA on NixOS. I suspect we may need to patchelf it.

@lovesegfault lovesegfault mentioned this pull request Jul 23, 2020
Merged
10 tasks
@vcunat
Copy link
Member

vcunat commented Jul 26, 2020

Updated within #93715.

@vcunat vcunat closed this Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovesegfault lovesegfault lovesegfault approved these changes

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@eljojo @lovesegfault @vcunat @Janik-Haag