Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.wheel: 0.33.6 -> 0.34.2 #92944

Closed
wants to merge 1 commit into from
Closed

python3Packages.wheel: 0.33.6 -> 0.34.2 #92944

wants to merge 1 commit into from

Conversation

siriobalmelli
Copy link
Contributor

Signed-off-by: Sirio Balmelli sirio@b-ad.ch

Motivation for this change

wheel >0.34 required for briefcase build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

FRidh
FRidh requested changes Jul 12, 2020
View reviewed changes
pkgs/development/python-modules/wheel/default.nix Outdated Show resolved Hide resolved
pkgs/development/python-modules/wheel/default.nix

catchConflicts = false;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need to check whether this is still needed

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, I got a clean build on Darwin and Linux without ... but I don't have sufficient CPU to reasonably rebuild all dependencies so cannot guarantee.

@FRidh FRidh self-assigned this Jul 12, 2020
jonringer
jonringer reviewed Jul 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this rebuilds almost all of the python packages, please target the staging branch

@siriobalmelli siriobalmelli changed the base branch from master to staging July 13, 2020 20:12
@siriobalmelli
python3Packages.wheel: 0.33.6 -> 0.34.2
60f3371 
Signed-off-by: Sirio Balmelli <sirio@b-ad.ch>
@siriobalmelli siriobalmelli deleted the briefcase_/wheel branch August 3, 2020 19:30
@jonringer
Copy link
Contributor

I went on vacation and this fell off my plate.

@siriobalmelli
Copy link
Contributor Author

I went on vacation and this fell off my plate.

No worries at all!
Happy you got some good R&R :)

I closed because I found a way around doing an upgrade on such a central package ... I will be better equipped to submit such PRs when I get my workstation online in a few months and I have enough compute to actually build all dependant packages on both Darwin and Linux

@jonringer
Copy link
Contributor

we periodically do large python package set updates. That would probably be a more appropriate time. Plus we have hydra compute resources, so we can efficiently build large package sets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh FRidh requested changes

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@siriobalmelli @jonringer @FRidh