Remove redundant XrInputSourceArray iterable test #24569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Jul 10, 2020
XRInputSourceArray_Iterable was failing on chromium, since as a ".html" and not a ".https.html" file, it was not loaded in a secure context, and thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill itself in if navigator.xr doesn't exist). However, on closer inspection, this is a redundant test case that is already covered by the idlharness. Fixed: 1104347 Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by: Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#787443}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-2293227
branch
from
9f3bff7
to
1f9766c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
XRInputSourceArray_Iterable was failing on chromium, since as a ".html"
and not a ".https.html" file, it was not loaded in a secure context, and
thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill
itself in if navigator.xr doesn't exist). However, on closer inspection,
this is a redundant test case that is already covered by the idlharness.
Fixed: 1104347
Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227
Commit-Queue: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#787443}