Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest to remove special handling of closed contours #670

Closed
dims12 opened this issue Aug 7, 2020 · 3 comments
Closed

Suggest to remove special handling of closed contours #670

dims12 opened this issue Aug 7, 2020 · 3 comments
Labels

Comments

@dims12
Copy link

dims12 commented Aug 7, 2020

System information

SolveSpace version: 2.3~7c1ca460

Operating system: Windows 10 Pro

Expected behavior

I think any "graph loop" (in graph theory sense) should be treated as closed contour.

Actual behavior

Only contours, built by closing tool, are treated as closed.

Additional information

In attached file there are 2 closed contours, but the program doesn't understand

it.

not closed contours.zip

@whitequark
Copy link
Contributor

There's no such thing as a "closing tool". SolveSpace considers any contour with exactly one cycle a "closed contour". This is also the only kind of contour that is usable with 3d operations like extrusion, which is why a message is shown when the condition isn't satisfied.

@dims12
Copy link
Author

dims12 commented Aug 7, 2020

See an attachement. It has 2 closed contours, but the program say they aren't.

image

@dims12
Copy link
Author

dims12 commented Aug 7, 2020

If extrusion needs some conditions, namely an application of extrusion tool should fail or warn. No need to indicate any errors if exctrusion tool was not called. Also no need to fail area calculation tool.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants