Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.protobuf: Use default version of protobuf #94920

Merged
merged 1 commit into from Aug 8, 2020
Merged

pythonPackages.protobuf: Use default version of protobuf #94920

merged 1 commit into from Aug 8, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Aug 8, 2020

Motivation for this change

This has no current effect because pkgs.protobuf is pkgs.protobuf3_12, but since we always want this to upgrade consistently with the default version of protobuf, we might as well say so.

(This is the PR form of a comment I made on #91446.)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Aug 8, 2020

I think we should leave a comment stating that "if a protobuf upgrade causes many Python packages to fail, please pin it here to the previous version".

@andersk
pythonPackages.protobuf: Use default version of protobuf
3c375e0 
This has no current effect because pkgs.protobuf is pkgs.protobuf3_12,
but since we always want this to upgrade consistently with the default
version of protobuf, we might as well say so.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk
Copy link
Contributor Author

andersk commented Aug 8, 2020

I would think that would be obvious, but sure, why not. Added.

@bhipple bhipple merged commit aed5964 into NixOS:master Aug 8, 2020
@andersk andersk deleted the python-protobuf-default branch December 26, 2022 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andersk @FRidh @bhipple