Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-blueline: init #191

Closed
wants to merge 16 commits into from
Closed

google-blueline: init #191

wants to merge 16 commits into from

Conversation

colemickens
Copy link
Member

@colemickens colemickens commented Aug 7, 2020 •
edited

The README.adoc contains the status. Shouldn't be merged. There are three kernels, two of which are mainline and build. I couldn't get the android kernel building...

TODO are in the README

README (status): rendered

@samueldr samueldr marked this pull request as draft August 7, 2020 21:15
@samueldr samueldr added 9. status: WIP The PR is not ready for merge, work in progress 4. type: port New device port labels Aug 7, 2020
@colemickens colemickens force-pushed the mobile-nixos-blueline branch 2 times, most recently from 2df918a to 59471f5 Compare October 2, 2020 04:44
@samueldr samueldr mentioned this pull request Oct 2, 2020
Merged
1 task
@colemickens colemickens force-pushed the mobile-nixos-blueline branch 4 times, most recently from 439d9ef to 9208aef Compare October 5, 2020 09:33
samueldr
samueldr reviewed Oct 6, 2020
View reviewed changes
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random thoughts.

I did not look at the kernel derivations at all since I suppose they're all still in development.

devices/google-blueline/default.nix Outdated Show resolved Hide resolved
devices/google-blueline/default.nix
mobile.device.firmware = firmware;
mobile.boot.stage-1.firmware = [ firmware ];

#mobile.system.vendor.partition = "/dev/disk/by-partlabel/vendor_a";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More of a TODO: check what is needed for the vendor_a partition to work.

Do we need to somehow support dynamic partitions? Probably.

devices/google-blueline/firmware/default.nix Outdated Show resolved Hide resolved
devices/google-blueline/default.nix Outdated Show resolved Hide resolved
modules/hardware-qualcomm.nix Outdated Show resolved Hide resolved
modules/initrd-logs.nix Outdated Show resolved Hide resolved
overlay/mobile-nixos/kernel/builder.nix Outdated Show resolved Hide resolved
overlay/mobile-nixos/kernel/builder.nix Outdated
@@ -322,6 +323,7 @@ stdenv.mkDerivation (inputArgs // {

buildFlags = [
kernelTarget
"Image.gz"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add it to installTargets in the kernel derivation I figure. Or maybe I'll play around with the ergonomics of building an lz4-compressed kernel.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's not quite enough, installTargets get appended after zinstall and just reordering them seems... fragile?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm, I thought that the order didn't matter here. I'll have to think about it.

@samueldr samueldr mentioned this pull request Oct 6, 2020
Closed
@colemickens colemickens force-pushed the mobile-nixos-blueline branch 10 times, most recently from 0fc90ba to ceafa08 Compare October 8, 2020 03:38
@colemickens
Copy link
Member Author

colemickens commented Oct 8, 2020 •
edited

README now has step-by-step instructions. cc: @craigem ;)

@colemickens colemickens force-pushed the mobile-nixos-blueline branch 7 times, most recently from 5a56c12 to 27938f1 Compare October 8, 2020 04:02
@colemickens colemickens force-pushed the mobile-nixos-blueline branch 5 times, most recently from 85f107f to 3948870 Compare October 8, 2020 04:05
@samueldr samueldr mentioned this pull request Jun 4, 2021
Closed
3 tasks
@samueldr
Copy link
Member

Hi!

We just had some major~ish changes, at least one affecting new ports. I would heavily suggest rebasing on top of the latest master update.

The main change affecting ports is that we now have required kernel configuration options, which set known good values to a lot of "difficult to guess" options. A simple bin/kernel-normalize-config should be all that is needed.

Hope this helps!

Technically this is what I would be saying... But I guess that #361 obsoletes this one? I don't mean to force you to close this one though, if you wanted to continue/restart working on that :).

@samueldr samueldr mentioned this pull request Sep 14, 2022
Merged
8 tasks
@samueldr
Copy link
Member

Closing, now that #361 is closed, and #511 is setting up the family stuff such that it should be usable as soon as upstream adds support.

If for any reason you want to re-open, feel free to.

@samueldr samueldr closed this Sep 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samueldr samueldr samueldr left review comments

Assignees
No one assigned
Labels
4. type: port New device port 9. status: WIP The PR is not ready for merge, work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@colemickens @samueldr