refactor: refactor jruby to allow multiple versions #94876
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzakaria
commented
Aug 7, 2020
| v9_2_12_0 = generic_jruby { | ||
| version = "9.2.12.0"; | ||
| sha256 = "013c1q1n525y9ghp369z1jayivm9bw8c1x0g5lz7479hqhj62zrh"; | ||
| rubyVersion = rubyVersion "2" "5" "7" ""; |
There was a problem hiding this comment.
> nix run -f $(pwd) jruby-group.v9_2_13_0 --command ruby -e 'puts RUBY_VERSION'
2.5.7| v9_2_13_0 = generic_jruby { | ||
| version = "9.2.13.0"; | ||
| sha256 = "0n5glz6xm3skrfihzn3g5awdxpjsqn2k8k46gv449rk2l50w5a3k"; | ||
| rubyVersion = rubyVersion "2" "5" "7" ""; |
There was a problem hiding this comment.
❯ nix run -f $(pwd) jruby-group.v9_2_12_0 --command ruby -e 'puts RUBY_VERSION'
[1 built, 25 copied (211.7 MiB), 67.4 MiB DL]
2.5.7| @@ -10084,7 +10084,8 @@ in | |||
|
|
|||
| sourceFromHead = callPackage ../build-support/source-from-head-fun.nix {}; | |||
|
|
|||
| jruby = callPackage ../development/interpreters/jruby { }; | |||
| jruby-group = callPackage ../development/interpreters/jruby {}; | |||
| jruby = jruby-group.latest; | |||
There was a problem hiding this comment.
this keeps all packages that rely on JRuby still working and backwards compatible
Many packages within Nix support multiple packages & a versionless attribute that tracks "latest"; This refactors the JRuby derivation to be similar to that of Ruby itself.
fzakaria
force-pushed
the
jruby-refactor
branch
from
dc9d5f7
to
1846317
Compare
fzakaria
commented
Aug 7, 2020
Comment on lines
-58
to
-61
| passthru = oldAttrs.passthru // { | ||
| devEnv = callPackage ../ruby/dev.nix { | ||
| ruby = jruby; | ||
| }; |
There was a problem hiding this comment.
This is unnecessary and inlined within the generic builder.
It relies on "self" to be self-referential to the ruby it's building.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Many packages within Nix support multiple packages & a versionless
attribute that tracks "latest";
This refactors the JRuby derivation to be similar to that of Ruby
itself.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)