Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rust: 1.45.0 -> 1.45.2 #94931

Merged
merged 1 commit into from Aug 11, 2020
Merged

rust: 1.45.0 -> 1.45.2 #94931

merged 1 commit into from Aug 11, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Aug 8, 2020

Since this is a patch release, I probably won’t wait for a Darwin user to confirm it works. But a check that fd builds would still be welcome.

Firefox and Thunderbird still don’t build with 1.45.x.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonringer
Copy link
Contributor

Firefox and Thunderbird still don’t build with 1.45.x.

Should we start keeping onto older rustc versions?

@alyssais
Copy link
Member Author

Firefox and Thunderbird still don’t build with 1.45.x.

Should we start keeping onto older rustc versions?

We currently have 1.44 and 1.45, and use 1.44 for building Firefox and Thunderbird. Are you proposing a change from this?

@jonringer
Copy link
Contributor

no, actually, that's exactly what I was suggesting. didn't realize it was already in place :)

jonringer
jonringer approved these changes Aug 10, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM

@alyssais alyssais merged commit 5d65255 into NixOS:staging Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@LnL7 LnL7 Awaiting requested review from LnL7

@Mic92 Mic92 Awaiting requested review from Mic92 Mic92 is a code owner

Assignees
No one assigned
Labels
6.topic: rust 10.rebuild-darwin: 501-1000 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alyssais @jonringer