kicad: reenable scriptingSupport #94934
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i'll probably be updating the kicad-unstable version in this PR every time one of my upstream issues gets fixed until this gets merged |
gebner
reviewed
Aug 23, 2020
gebner
approved these changes
Aug 23, 2020
to prevent duplication when just the date changes kicad.libraries should be fixed output derivations?
94108 fixed the wxPython dependency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#94108 fixed the wxPython dependency, this is probably required for #88923
Things done
reenable ScriptingSupport
change the components to use the hash of their source for the name, instead of the version/date
update kicad-unstable (quite a few new fixes and features)
Tested using sandboxing (nix.useSandbox on NixOS, or option
sandboxinnix.confon non-NixOS linux)Built on platform(s)
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using
nix-shell -p nixpkgs-review --run "nixpkgs-review wip"Tested execution of all binary files (usually in
./result/bin/)Determined the impact on package closure size (by running
nix path-info -Sbefore and after)kicad-small: from711685672to1114861552Ensured that relevant documentation is up to date
Fits CONTRIBUTING.md.