Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asdf: don't restrict to linux, since darwin works too #94919

Merged
merged 1 commit into from Aug 10, 2020

Conversation

purcell
Copy link
Member

@purcell purcell commented Aug 8, 2020

Motivation for this change

The common lisp "asdf" system works on multiple Unix-likes, not just Linux. With this loosened platforms restriction, I was able to install lispPackages.cffi on Darwin, for instance.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 6.topic: darwin Running or building packages on Darwin 8.has: package (new) labels Aug 8, 2020
@ofborg ofborg bot requested a review from 7c6f434c August 8, 2020 02:51
@7c6f434c 7c6f434c merged commit 30641fa into NixOS:master Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants