Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly require Polkit in the libvirtd module in the form of an assertion #94926

Merged
merged 1 commit into from Jun 7, 2021

Conversation

jakobrs
Copy link
Contributor

@jakobrs jakobrs commented Aug 8, 2020

Motivation for this change

See #87576 and #94861. The libvirtd module requires Polkit, this just adds an assertion.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stale
Copy link

stale bot commented Jun 2, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@jakobrs
Copy link
Contributor Author

jakobrs commented Jun 2, 2021

I'd still like for this to be merged. The stale bot document says that I should request for review by someone who usually merges similar contributions, but I couldn't figure out how to request reviews, and the past 10 contributions were merged by different people, so I'm just pinging one of you: @sternenseemann.

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 2, 2021
@sternenseemann
Copy link
Member

Since libvirtd supports multiple authentication schemes this doesn't seem like a correct change to me. We probably should add an option choosing the authentication scheme (as opposed of handling it via extraConfig solely) additionally, so we can factor it in in the assert.

@jakobrs
Copy link
Contributor Author

jakobrs commented Jun 3, 2021

Yes, that's a fair point. However, in that case someone else would have to implement it (since I don't have enough motivation to work on this as I'm not even using libvirt at the moment). Although it would be possible to use this until someone else eventually decides to implement non-polkit-based auth.

@SuperSandro2000 SuperSandro2000 requested review from SuperSandro2000 and removed request for SuperSandro2000 June 3, 2021 10:32
@sternenseemann sternenseemann merged commit 475c007 into NixOS:master Jun 7, 2021
@jakobrs jakobrs deleted the libvirt-polkit-assertion branch June 7, 2021 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants