Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

androidStudioPackages.beta: 4.1.0.14 -> 4.1.0.15 #94935

Closed
wants to merge 1 commit into from
Closed

androidStudioPackages.beta: 4.1.0.14 -> 4.1.0.15 #94935

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Aug 8, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ghost
Copy link
Author

ghost commented Aug 8, 2020

Tested by building and running a small android project.

@maxhille
Copy link
Contributor

4.1 RC 1 is out already. Will this PR be adapted or does it need to be superseded by a new one?

@ghost
Copy link
Author

ghost commented Aug 14, 2020

I am not sure what the procedure is. It seems in general android studio releases are more common than merges requests being closed.

@ghost
Copy link
Author

ghost commented Aug 16, 2020

Closing in favour of #94364

@ghost ghost closed this Aug 16, 2020
@ghost ghost deleted the update/android-studio-beta branch August 16, 2020 11:12
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxhille @meutraa