Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/tests: add test for firejail #94878

Merged
merged 1 commit into from Aug 14, 2020
Merged

nixos/tests: add test for firejail #94878

merged 1 commit into from Aug 14, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Aug 7, 2020 •
edited

Motivation for this change

Adds some test for the firejail package:

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp
Copy link
Member Author

stigtsp commented Aug 7, 2020

@GrahamcOfBorg build firejail.tests

@stigtsp
Copy link
Member Author

stigtsp commented Aug 8, 2020

@GrahamcOfBorg build firejail.tests

@stigtsp stigtsp marked this pull request as draft August 9, 2020 21:42
@stigtsp
Copy link
Member Author

stigtsp commented Aug 9, 2020

Does not merge cleanly with #95015

@stigtsp stigtsp marked this pull request as ready for review August 10, 2020 04:44
@stigtsp
Copy link
Member Author

stigtsp commented Aug 10, 2020

@GrahamcOfBorg build firejail.tests

@stigtsp stigtsp requested a review from 7c6f434c August 10, 2020 04:46
@stigtsp
Copy link
Member Author

stigtsp commented Aug 10, 2020

@GrahamcOfBorg build firejail.tests

(Apologies for the build spam)

@worldofpeace worldofpeace merged commit bea5560 into NixOS:master Aug 14, 2020
@worldofpeace
Copy link
Contributor

Thanks @stigtsp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@stigtsp @worldofpeace @7c6f434c