Reviewed points

• package name fits guidelines
• package version fits guidelines
• package build on Darwin
• executables tested on Darwin
• all depending packages build

Possible improvements

> minio
NAME:
  minio - High Performance Object Storage

DESCRIPTION:
  Build high performance data infrastructure for machine learning, analytics and application data workloads with MinIO

USAGE:
  minio [FLAGS] COMMAND [ARGS...]

COMMANDS:
  server   start object storage server
  gateway  start object storage gateway

FLAGS:
  --certs-dir value, -S value  path to certs directory (default: "/Users/lclaude/.minio/certs")
  --quiet                      disable startup information
  --anonymous                  hide sensitive information from logging
  --json                       output server logs and startup information in json format
  --help, -h                   show help
  --version, -v                print the version

VERSION:
  DEVELOPMENT.GOGET

Can you try to provide a better version message?

Comments

@ludovicc unfortunately, the version issue seems to be pre-existing and I don't know enough about how go works to get what seems to be some linker flags passed in properly. Do you have any advice here?

Could it be that buildFlags overrides buildFlagsArray? If yes addig your flags to buildFlagsArray should still keep the version

@bachp I mean to say that building minio from nixpkgs on master still results in a DEVELOPMENT.GOGET version it seems, this change doesn't impact that.

@afontaine You are right. I will fix this in another MR. @ludovicc We should not block this change because of an unrelated issue.

yes, please don't block this MR because of this minor issue. @bachp a separate MR would be great, thanks.

I'm sorry, one last remark: @afontaine you added the flag -tags=kqueue, but I can see also -trimpath being used. Is that relevant to this build? Those flags also seem to be used for all architectures if I understand well goreleaser config.

https://github.com/minio/minio/blob/73890f31af5f1247c1f5b8131f136d1045d6b5f6/.goreleaser.yml#L67
https://github.com/minio/minio/blob/36d36fab0bfeb0e91099e852408d0e1ac2e06440/Makefile#L61

@ludovicc you seem correct, and it looks like all these flags seem to be used across all architectures, so I removed the darwin check for -tags kqueue as well.

and a little more playing around and things now all fit into the buildFlagsArray properly 🎉

it looks like CGO is disabled on linux builds as well, so I might as well just keep it consistent.

I reviewed the latest update and it works well on Darwin. Version is still DEVELOPMENT.GOGET but it's a very minor annoyance.

Ah I just noticed the merge conflicts, they are all fixed up now 🚀

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/239