Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk: enable qt gui support #94877

Closed
wants to merge 1 commit into from
Closed

vtk: enable qt gui support #94877

wants to merge 1 commit into from

Conversation

matthuszagh
Copy link
Contributor

@matthuszagh matthuszagh commented Aug 7, 2020 •
edited

Motivation for this change

Part of this PR. @jonringer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from knedlsepp August 7, 2020 17:02
@bcdarwin
Copy link
Member

bcdarwin commented Aug 7, 2020 •
edited

nixpkgs-review succeeds, but lib/libvtkGUISupportQt-8.2.so.1 is already present in the output of vtkWithQt5 on master (more generally the results of find result -name '*GUI*' are identical), so it seems like this option is already implied by VTK_Group_Qt in the current version of VTK?

@matthuszagh
Copy link
Contributor Author

@bcdarwin thanks for the review and it seems you're right. Thanks for spotting that. I had originally written this PR for an earlier version of the derivation that didn't provide the Qt GUI support. Closing this.

@matthuszagh matthuszagh closed this Aug 7, 2020
@matthuszagh matthuszagh deleted the vtk branch August 7, 2020 18:12
@bcdarwin
Copy link
Member

bcdarwin commented Aug 9, 2020

[Probably obviated by #84772.]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bcdarwin bcdarwin Awaiting requested review from bcdarwin

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthuszagh @bcdarwin