Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

_1password-gui: init at 0.8.0 #94923

Merged
merged 1 commit into from Aug 9, 2020
Merged

_1password-gui: init at 0.8.0 #94923

merged 1 commit into from Aug 9, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Aug 8, 2020 •
edited

Motivation for this change

Add the new (electron-based) GUI for 1Password.

Ideally, this would just be named 1password. However,

  • variable names cannot start with a number;
  • _1password already exists. This should probably have been named op (since that is what upstream calls it), but the attribute is taken now. So, I decided to call the attribute _1password-gui.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
gui launches fine

https://github.com/NixOS/nixpkgs/pull/94923
1 package built:
_1password-gui

@jonringer jonringer merged commit 19e6323 into NixOS:master Aug 9, 2020
@evanjs
Copy link
Member

evanjs commented Aug 14, 2020

Seems to work great so far.

I knew somebody would add this promptly after reading the original post.

Thank you!

@danieldk danieldk deleted the 1password-gui branch August 17, 2020 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @evanjs @jonringer