go-dqlite: init at 1.7.0 #94924
Closed
go-dqlite: init at 1.7.0 #94924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've used the dqlite-demo for the Jepsen test mentioned here: canonical/dqlite#258, so I'm pretty confident that this works. |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
tomberek
approved these changes
Sep 6, 2020
|
builds, runs, and functions as expected on NixOS. |
doronbehar
requested changes
Dec 16, 2020
Comment on lines
+21
to
+23
| dqlite.dev | ||
| libco-canonical.dev | ||
| raft-canonical.dev |
|
|
||
| buildFlags = [ "-tags libsqlite3" ]; | ||
|
|
||
| doCheck = false; |
SuperSandro2000
requested changes
Jan 18, 2021
Comment on lines
+8
to
+9
| }: | ||
| buildGoModule rec { |
There was a problem hiding this comment.
Suggested change
| }: | |
| buildGoModule rec { | |
| }: | |
| buildGoModule rec { |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing due to OP not responding to reviews, and deleting their branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add go-dqlite, which includes a binary for interfacing with dqlite clusters.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)