Font joypixels emoji #94892
Merged
Font joypixels emoji #94892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
infinisil
requested changes
Aug 7, 2020
jtojnar
reviewed
Aug 8, 2020
toonn
force-pushed
the
font-joypixels-emoji
branch
2 times, most recently
from
998035f
to
e6c9a23
Compare
doronbehar
added a commit
to doronbehar/nixpkgs
that referenced
this pull request
Sep 22, 2020
Do it before buildInputs per: NixOS#94892 (comment) Remove unneed, BLAS_LIBS and LAPACK_LIBS from environment - the libraries are detected just fine when in buildInputs.
10 tasks
doronbehar
added a commit
to doronbehar/nixpkgs
that referenced
this pull request
Sep 22, 2020
Use `pname` and `version`. Use my preferred indentation style. Use makeFlagsArray in preBuild instead of overriding configurePhase, per: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md Assert that lapack and blas are compatible regarding 64 bit indexing, do it near evaluation of preBuild, per jtojnar's explanation: NixOS#94892 (comment) Use gpl3Plus, as gpl3 is unclear and deprecated.
|
Whoops, been waiting on activity for this. Could've sworn I'd pressed the ready-for-review button before. |
The Arch Linux endpoint was not intended to be used as-is by other distros. I have asked for and received a proper license with a dedicated endpoint for NixOS.
The JoyPixels font comes with a license which requires explicit acceptance by the user.
Switch from an overridden variable to an option specified in configuration.nix or config.nix: ``` joypixels.acceptLicense = true; ```
Specifying the system-specific variables for x86_64-darwin and x86_64-linux is too restrictive, excluding for example i686-linux. Since macOS seems to be the odd one out we can special-case only x86_64-darwin.
x86_64-darwin is too specific because macOS runs on multiple architectures.
The url was changed on request.
By moving the assert concerning license acceptance into the src
attribute license acceptance can be expressed with an override,
`joypixels.override { acceptLicense = true; }`.
After some back and forth with JoyPixels they agreed to creating a version of their font for macOS that does not use the exact same name as the Apple Color Emoji default font. This naming collision meant it was impossible to configure applications to use the JoyPixels emoji font unless you disabled the Apple Color Emoji font using Font Book. Which meant the JoyPixels font could either replace the Apple Color Emoji font completely or only fill in the gaps in that font (on my system "hot face" isn't in the system font) but not be used entirely for specific apps or be used with the system font as a back up.
Also clean up formatting.
jtojnar
force-pushed
the
font-joypixels-emoji
branch
from
e6c9a23
to
5902a08
Compare
jtojnar
approved these changes
Oct 22, 2020
doronbehar
added a commit
to doronbehar/nixpkgs
that referenced
this pull request
Dec 5, 2020
Instead of asserting that lapack and blas are both not using 64 bit index size, only make sure they are index size compatible. Plus, do it when evaluating buildInputs, per: NixOS#94892 (comment) Don't pass SUNDIALS_INDEX_TYPE=int32_t if blas && lapack are compiled with 64 bit index size. Bonus: Use checkTarget and not an overrided checkPhase, per: https://github.com/jtojnar/nixpkgs-hammering/blob/master/explanations/explicit-phases.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The JoyPixels emoji font (formerly EmojiOne) was packaged using a CDN endpoint created for Arch Linux.
Arch Linux received an altered license for distribution of the font. Furthermore, the license requires explicit acceptance from users. And last but not least, as-is the font doesn't work on macOS.
I expect foss licenses to be complied to. In turn, this means we should respect the terms other projects put in their licenses. I contacted the JoyPixels licensing team and they were happy to provide CDN endpoints and similarly altered licenses for distribution of their font for NixOS and nix-darwin.
I altered the expression to work on macOS, which requires downloading and installing a "TrueType Collection" file rather than the TrueType font file. I also updated the licensing information and the package now requires an override to indicate acceptance of the license before you can install it.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)