Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jetbrains.*: 2020.1.* -> 2020.2 #94893

Merged
merged 1 commit into from Aug 18, 2020
Merged

jetbrains.*: 2020.1.* -> 2020.2 #94893

merged 1 commit into from Aug 18, 2020

Conversation

LeUlukai
Copy link
Contributor

@LeUlukai LeUlukai commented Aug 7, 2020

Motivation for this change

The jetbrain products have been updated with new cool features.

Updating: I just ran update.pl.

Testing: CLion is the only program that I tested more extensively than just launching.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LeUlukai LeUlukai requested a review from edwtjo as a code owner August 7, 2020 20:25
jonringer
jonringer approved these changes Aug 9, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94893 1

11 packages built: - jetbrains.clion - jetbrains.datagrip - jetbrains.goland - jetbrains.idea-community - jetbrains.idea-ultimate - jetbrains.mps - jetbrains.phpstorm - jetbrains.pycharm-community - jetbrains.pycharm-professional - jetbrains.ruby-mine - jetbrains.webstorm

@raboof
Copy link
Member

raboof commented Aug 18, 2020

Tested compiling a Scala project with idea-community - seems to work. Running the tests produces an error, but the same error as it did before on this project :D

jonringer
jonringer approved these changes Aug 18, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94893 1

11 packages built:
- jetbrains.clion
- jetbrains.datagrip
- jetbrains.goland
- jetbrains.idea-community
- jetbrains.idea-ultimate
- jetbrains.mps
- jetbrains.phpstorm
- jetbrains.pycharm-community
- jetbrains.pycharm-professional
- jetbrains.ruby-mine
- jetbrains.webstorm

@jonringer jonringer merged commit 0a84375 into NixOS:master Aug 18, 2020
@LeUlukai LeUlukai deleted the jetbrains-update branch August 18, 2020 16:25
@jonringer
Copy link
Contributor

hmm looks like I forgot tomerge this last time. Sorry abou thtat

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@edwtjo edwtjo Awaiting requested review from edwtjo edwtjo is a code owner

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@LeUlukai @raboof @jonringer @Janik-Haag