Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arduino-cli: init at 0.11.0 #94899

Merged
merged 1 commit into from Aug 8, 2020
Merged

arduino-cli: init at 0.11.0 #94899

merged 1 commit into from Aug 8, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Aug 7, 2020

Motivation for this change

Arduino is a popular microcontroller development board ecosystem and arduino-cli is the flagship command line utility for interacting with Arduino projects.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member Author

ryantm commented Aug 7, 2020

This is the first time I've use a buildFHSUserEnv, so please check my work!

doronbehar
doronbehar reviewed Aug 8, 2020
View reviewed changes
Copy link
Contributor

@doronbehar doronbehar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passes nixpkgs-review build and --help + more commands tests.

pkgs/development/arduino/arduino-cli/default.nix Outdated Show resolved Hide resolved
@ryantm ryantm merged commit 88c9526 into NixOS:master Aug 8, 2020
@ryantm ryantm deleted the arduino-cli branch August 8, 2020 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ryantm @doronbehar