Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maintainers: add gvolpe #94900

Closed
wants to merge 1 commit into from
Closed

maintainers: add gvolpe #94900

wants to merge 1 commit into from

Conversation

gvolpe
Copy link
Member

@gvolpe gvolpe commented Aug 7, 2020

Motivation for this change

Adding myself as a maintainer of dconf2nix, to be introduced in #94891

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Artturin
Copy link
Member

Artturin commented Aug 7, 2020

it should be in the same pr but a new commit not a separate pr

@gvolpe
Copy link
Member Author

gvolpe commented Aug 8, 2020

Thanks @Artturin , my bad

@gvolpe gvolpe closed this Aug 8, 2020
@gvolpe gvolpe deleted the maintainers/gvolpe branch August 8, 2020 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gvolpe @Artturin