Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: cb8a5e5b8746
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: bc7b404b1a86
Choose a head ref
  • 2 commits
  • 2 files changed
  • 1 contributor

Commits on Aug 8, 2020

  1. python3Packages.pytorch: fix Darwin build by disabling GCD 

    PyTorch 1.6.0 has updated the vendored pthreadpool library, which has recently
added support for Grand Central Dispatch. Unfortunately, it uses functionality
(DISPATCH_APPLY_AUTO) that is only available since macOS 10.13, whereas we are
still using 10.12 libraries.

We can't directly pass through option to vendored libraries, since the setup.py
scripts creates/filters the options that are passed to CMake. So, instead, this
adds a small patch that disables the GCD functionality in pthreadpool.
    @danieldk @FRidh
    danieldk authored and FRidh committed Aug 8, 2020
    Copy the full SHA
    6ffc0fd View commit details
    Browse the repository at this point in the history

  2. python3Packages.pytorch: fix library names in lib output on Darwin 

    The library name fixup was attempted on the dev output, whereas it should be
applied to the lib output.
    @danieldk @FRidh
    danieldk authored and FRidh committed Aug 8, 2020
    Copy the full SHA
    bc7b404 View commit details
    Browse the repository at this point in the history