Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.jupyterhub: 1.0.0 -> 1.1.0 #94885

Merged
merged 2 commits into from Aug 8, 2020
Merged

pythonPackages.jupyterhub: 1.0.0 -> 1.1.0 #94885

merged 2 commits into from Aug 8, 2020

Conversation

chiroptical
Copy link
Contributor

Motivation for this change

Experienced an issue with JupyterHub 1.0.0 which is resolved by upgrading to 1.1.0. During the upgrade, determined that jupyter-telemetry is a build dependency.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Unsure how to proceed (errors seem unrelated to change)
  • Command nix-shell -p nixpkgs-review --run "nixpkgs-review wip" fails with Python XML related error
  • Command nix path-info -S errors out

Related: #94866 (PR made against wrong branch, closed prematurely by me 馃槥) #94783

@chiroptical chiroptical mentioned this pull request Aug 7, 2020
Closed
10 tasks
@ofborg ofborg bot requested review from ixxie and cstrahan August 7, 2020 19:11
jonringer
jonringer approved these changes Aug 8, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94885 1

8 packages built: - python37Packages.jupyter-telemetry - python37Packages.jupyterhub - python37Packages.jupyterhub-ldapauthenticator - python37Packages.oauthenticator - python38Packages.jupyter-telemetry - python38Packages.jupyterhub - python38Packages.jupyterhub-ldapauthenticator - python38Packages.oauthenticator

@jonringer jonringer merged commit b794182 into NixOS:master Aug 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@ixxie ixxie Awaiting requested review from ixxie

@cstrahan cstrahan Awaiting requested review from cstrahan

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chiroptical @jonringer