Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prosody-modules: update to revision 2dcbc01c9931 #94916

Merged
merged 1 commit into from Aug 8, 2020
Merged

prosody-modules: update to revision 2dcbc01c9931 #94916

merged 1 commit into from Aug 8, 2020

Conversation

ju1m
Copy link
Contributor

@ju1m ju1m commented Aug 8, 2020 •
edited

Motivation for this change

This update is needed to have a working mod_turncredentials.

Things done

Update communityModules to the latest tip of https://hg.prosody.im/prosody-modules .

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from fpletz and globin August 8, 2020 02:33
@picnoir
Copy link
Member

picnoir commented Aug 8, 2020 •
edited

Is it me or did ofborg failed to evaluate the passthru tests?

@GrahamcOfBorg test prosody

@picnoir
Copy link
Member

picnoir commented Aug 8, 2020 •
edited

Could you rename your commit to

prosody: update to revision 2dcbc01c9931

It'll make easier for the automated tooling to understand what the commit is about.

Other than that, LGTM, let's merge it.

picnoir
picnoir approved these changes Aug 8, 2020
View reviewed changes
Copy link
Member

@picnoir picnoir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@picnoir picnoir merged commit b50ef9a into NixOS:master Aug 8, 2020
@ju1m ju1m deleted the prosody branch April 23, 2022 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir approved these changes

@fpletz fpletz Awaiting requested review from fpletz

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ju1m @picnoir