Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] xfce.xfce4-vala-panel-appmenu-plugin: 0.7.3.0 -> 0.7.3.2 #94903

Closed
wants to merge 1 commit into from
Closed

[WIP] xfce.xfce4-vala-panel-appmenu-plugin: 0.7.3.0 -> 0.7.3.2 #94903

wants to merge 1 commit into from

Conversation

LouisDK1
Copy link
Contributor

@LouisDK1 LouisDK1 commented Aug 7, 2020

Motivation for this change

xfce.xfce4-vala-panel-appmenu-plugin: 0.7.3.2

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Aug 7, 2020 •
edited

@rycee When I try to build this package I get this error:
/nix/store/r51x5v9wi3pqkrq1bylz37x51msjfj7a-pango-1.45.3-dev/include/pango-1.0/pango/pango-coverage.h:28:10: fatal error: hb.h: No such file or directory

Searching around it looks like need to "include" hb.h from harfbuzz. I tried this but it does not seem to do the trick:
configureFlags = [ "CPPFLAGS=-I${harfbuzz}/include/harfbuzz" ];

Hope you can help :)

@ofborg ofborg bot added the 6.topic: xfce The Xfce Desktop Environment label Aug 8, 2020
@ofborg ofborg bot requested a review from jD91mZM2 August 8, 2020 00:19
@jD91mZM2
Copy link
Member

jD91mZM2 commented Aug 9, 2020

I'm sorry, I don't know. But it seems like they're talking about cmake-vala when searching around, maybe that needs to be included in the build somehow? their gitlab-ci.yml

@LouisDK1
Copy link
Contributor Author

LouisDK1 commented Aug 9, 2020

I'm sorry, I don't know. But it seems like they're talking about cmake-vala when searching around, maybe that needs to be
@jD91mZM2
included in the build somehow? their gitlab-ci.yml

It sounds like I should make a separate package called cmake-vala. Will look into that.

@stale
Copy link

stale bot commented Feb 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Feb 6, 2021
@FliegendeWurst
Copy link
Member

This package was removed in #114676

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jD91mZM2 jD91mZM2 Awaiting requested review from jD91mZM2

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: xfce The Xfce Desktop Environment 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LouisDK1 @jD91mZM2 @FliegendeWurst