Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faust: unstable-2020-06-08 -> unstable-2020-08-03 #93633

Merged
merged 3 commits into from Aug 16, 2020
Merged

faust: unstable-2020-06-08 -> unstable-2020-08-03 #93633

merged 3 commits into from Aug 16, 2020
+21 −12

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jul 22, 2020 •
edited

Motivation for this change

There was a new faust release in the meantime, but it has a bug that is fixed in this commit.

See: grame-cncm/faust#473

I also did some housekeeping and update a related pkg: faustlive.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I tested this compiler by building all pkgs in nixpkgs that use it.
The only exception is the pure module, since idk how to test it.

@ofborg ofborg bot requested a review from pmahoney August 1, 2020 12:27
@magnetophon
faust: unstable-2020-06-08 -> unstable-2020-08-03
2dda10a 
there was a release in the meantime, ut it has a bug that is fixed in
this commit.

See: grame-cncm/faust#473
@magnetophon
faust: temporarily remove emscripten:
1fd81c9 
it doesn't build at the moment and is not essential to faust
@magnetophon
faustlive: 2017-12-05 -> 2.5.4
9796dfc
@magnetophon magnetophon changed the title faust: unstable-2020-06-08 -> 2.27.1 faust: unstable-2020-06-08 -> unstable-2020-08-03 Aug 3, 2020
@orivej-nixos orivej-nixos merged commit 9e2c0f5 into NixOS:master Aug 16, 2020
@magnetophon magnetophon deleted the faust branch August 17, 2020 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmahoney pmahoney Awaiting requested review from pmahoney

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@magnetophon @orivej-nixos