Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remind: 03.01.16 -> 03.03.01 #93593

Merged
merged 1 commit into from Jul 22, 2020
Merged

remind: 03.01.16 -> 03.03.01 #93593

merged 1 commit into from Jul 22, 2020

Conversation

markus1189
Copy link
Contributor

@markus1189 markus1189 commented Jul 21, 2020 •
edited

Motivation for this change

Update remind to the latest version as per https://dianne.skoll.ca/projects/remind/

also, use pname and interpolate version into the download url

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@markus1189 markus1189 marked this pull request as ready for review July 21, 2020 13:43
@dasj19
Copy link
Contributor

dasj19 commented Jul 21, 2020

Tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93593". Builds and runs just fine. (You can check the 3rd checkbox in the description).

@ofborg ofborg bot requested review from KoviRobi and 7c6f434c July 21, 2020 19:04
@KoviRobi
Copy link
Contributor

As long as Nix isn't misinterpreting the zero padding in the version to mean 3.1 > 3.03, LGTM. I'm not using remind these days though.

@danieldk danieldk merged commit 479dc4a into NixOS:master Jul 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 approved these changes

@KoviRobi KoviRobi Awaiting requested review from KoviRobi

@7c6f434c 7c6f434c Awaiting requested review from 7c6f434c

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@markus1189 @dasj19 @KoviRobi @danieldk