Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nix
base: 1346da4669b2
Choose a base ref
...
head repository: NixOS/nix
compare: 0951330680af
Choose a head ref
  • 14 commits
  • 2 files changed
  • 3 contributors

Commits on Jun 17, 2020

  1. Eliminate old TeeSink abstraction

    This was introduced in fa125b9, and
    then "reverted" in 1cf4801, except that
    revert left the struct around doing nothing useful.
    
    We're removing it all the way now because we want to make a new
    `TeeSink` complementing the already-exiting `TeeSource`, that is
    actually a completely different concept as far as the class hierarchy is
    concerned.
    meditans authored and Ericson2314 committed Jun 17, 2020
    Copy the full SHA
    fb05a6a View commit details
    Browse the repository at this point in the history
  2. Create a new TeeSink abstraction

    This is a bit complex because we want to expose extra functionality the
    wrapped class has. Perhaps there is some inheritancy trickery to do this
    nicer, but I don't know it, and this is the first thing we tried after a
    series of attempts that did build.
    
    This design is kind of like that of Rust's Writer, Reader, or Iter
    adapters, which impliment more traits based on what the inner type
    implements.
    meditans authored and Ericson2314 committed Jun 17, 2020
    Copy the full SHA
    289b9b8 View commit details
    Browse the repository at this point in the history
  3. Replace TransferItem::status with a local variable

    Everywhere seems to use `getHTTPStatus` now.
    meditans authored and Ericson2314 committed Jun 17, 2020
    Copy the full SHA
    a835c74 View commit details
    Browse the repository at this point in the history
  4. Copy the full SHA
    004570a View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. Copy the full SHA
    74b219e View commit details
    Browse the repository at this point in the history
  2. Prevent '%' in URL from causing crashes

    We have a larger problem that passsing computed strings to the first
    variable argument of many exception constructors is unsafe because that
    first variable argument is interpreted not as a plain string, but format
    string, and if it contains '%' boost::format will abort, since there are
    no arguments to the format string.
    
    In this particular instance '%' was used as part of an escape code in a
    URL, which, when the download failed, caused Nix to abort displaying the
    `FileTransferError`.
    Ericson2314 committed Jun 18, 2020
    Copy the full SHA
    639e20d View commit details
    Browse the repository at this point in the history
  3. Copy the full SHA
    fb432b0 View commit details
    Browse the repository at this point in the history
  4. Fix bugs

     - Bad dynamic cast target ...classic
    
     - std::shared_ptr need explicit deref
    Ericson2314 committed Jun 18, 2020
    Copy the full SHA
    1b23fe4 View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2020

  1. Copy the full SHA
    465daa9 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2020

  1. Copy the full SHA
    2d2a10e View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2020

  1. Copy the full SHA
    e3a3406 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2020

  1. Use heuristics to decide when to show the response

    Due to #3841 we don't know how print
    different messages for different verbosity levels.
    meditans committed Jul 20, 2020
    Copy the full SHA
    0ca9744 View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2020

  1. Copy the full SHA
    54e507a View commit details
    Browse the repository at this point in the history
  2. Merge pull request #3714 from obsidiansystems/add-body-to-network-errors

    Add response body to network errors
    edolstra committed Jul 21, 2020
    Copy the full SHA
    0951330 View commit details
    Browse the repository at this point in the history