nixos/networkd: Add support for networking.defaultGateway.interface with networking.useNetworkd #93598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
20a4cca
to
56db2f0
Compare
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
56db2f0
to
52e9350
Compare
10 tasks
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
52e9350
to
d3f9d2b
Compare
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
d3f9d2b
to
0163625
Compare
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
0163625
to
df6ad01
Compare
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
df6ad01
to
cea3c3c
Compare
stale
bot
removed
the
2.status: stale
…ith networking.useNetworkd
This commit drops the assertions preventing the use of `networking.defaultGateway.interface` with `networking.useNetworkd`.
It changes the `genericNetwork` function in `network-interfaces-systemd.nix` to only consider a default gateway "globally" if its `interface` option is `null`.
It adds an `interfaceGateways` function, which returns the addresses specified in `network.defaultGateway{,6}.address` if their `interface` option is specified and matches the name of the given interface. Each interface now has these gateways added to its definition.
duairc
force-pushed
the
systemd-networkd-gateway-interface
branch
from
cea3c3c
to
ac3cc6d
Compare
|
I'm sorry to see that this went unreviewed for 3+ years! 😱 Before I saw this, I wrote #258695 which gets at the same idea. |
|
Already addressed by #258695 as already mentioned, so closing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I'm not sure if there's a good reason why this was specifically disallowed, but it seems quite easy to make it work. I get the impression that there's a vague intention to deprecate the
network.defaultGateway*options in the future, which I would be in favour of, but until that happens I don't see why there should be a divergence betweenuseNetworkdbeingtrueorfalse. The reason I care about is this is that I'm writing a NixOS module that tries to abstract out the network configuration on a specific hosting provider, and with this change it can be independent ofuseNetworkdbeing enabled or not, which seems better for modularity.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)