Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perlPackages.CryptOpenPGP: init at 1.12 #93599

Merged
merged 1 commit into from Jul 26, 2020
Merged

perlPackages.CryptOpenPGP: init at 1.12 #93599

merged 1 commit into from Jul 26, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented Jul 21, 2020

This PR adds the Crypt::OpenPGP Perl module, and several dependencies.

dependencies:
perlPackages.AltCryptRSABigInt: init at 0.06
perlPackages.ConvertASCIIArmour: init at 1.4
perlPackages.CryptCAST5_PP: init at 1.04
perlPackages.CryptDES_EDE3: init at 0.01
perlPackages.CryptDSA: init at 1.17
perlPackages.CryptRIPEMD160: init at 0.06
perlPackages.CryptTwofish: init at 2.17
perlPackages.DataBuffer: init at 0.04
perlPackages.DigestMD2: init at 2.04
perlPackages.MathPrimeUtil: init at 0.73
perlPackages.MathPrimeUtilGMP: init at 0.52
perlPackages.TieEncryptedHash: init at 1.24

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from volth and aanderse July 21, 2020 17:12
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

@aanderse
Copy link
Member

@stigtsp ping on darwin failure.

@stigtsp
Copy link
Member Author

stigtsp commented Jul 23, 2020 •
edited

@stigtsp ping on darwin failure.

Unable to reproduce locally on darwin, need to look at the tests. Could be some impurity perhaps.

https://logs.nix.ci/?key=nixos/nixpkgs.93599&attempt_id=f9be3dab-1b4c-4ef9-82af-1487dce275ba

t/13-keygen.t .... 15/29
#   Failed test 'public key_id matches secret key_id'
#   at t/13-keygen.t line 29.
Non-UTF8 data omitted from the log.
Non-UTF8 data omitted from the log.
#   Failed test 'serialized public key_id matches secret key_id'
#   at t/13-keygen.t line 50.
Non-UTF8 data omitted from the log.
Non-UTF8 data omitted from the log.
# Looks like you failed 2 tests of 29.
t/13-keygen.t .... Dubious, test returned 2 (wstat 512, 0x200)
Failed 2/29 subtests
t/51-gh7.t ....... ok
Test Summary Report
-------------------
t/13-keygen.t  (Wstat: 512 Tests: 29 Failed: 2)
  Failed tests:  19, 28
  Non-zero exit status: 2
Files=15, Tests=340, 17 wallclock secs ( 0.13 usr  0.07 sys + 13.90 cusr  3.43 csys = 17.53 CPU)
Result: FAIL
Failed 1/15 test programs. 2/340 subtests failed.
make: *** [Makefile:1028: test_dynamic] Error 255
builder for '/nix/store/maviaxag9bf4mj2qx4a8qzim9sljy2ia-perl5.30.3-Crypt-OpenPGP-1.12.drv' failed with exit code 2

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

@stigtsp stigtsp marked this pull request as draft July 23, 2020 11:42
@stigtsp stigtsp force-pushed the package/perl-crypt-openpgp-init branch from 196c048 to 375559e Compare July 23, 2020 12:16
@stigtsp
Copy link
Member Author

stigtsp commented Jul 23, 2020 •
edited

Attempting to get more information about the failure:

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

@stigtsp stigtsp mentioned this pull request Jul 23, 2020
Closed
@stigtsp
Copy link
Member Author

stigtsp commented Jul 24, 2020

@aanderse can you trigger a build for me? i'm looking to see if darwin fails, and what the output it.

@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

@stigtsp
perlPackages.CryptOpenPGP: init at 1.12
e68e4ca 
dependencies:
perlPackages.AltCryptRSABigInt: init at 0.06
perlPackages.ConvertASCIIArmour: init at 1.4
perlPackages.CryptCAST5_PP: init at 1.04
perlPackages.CryptDES_EDE3: init at 0.01
perlPackages.CryptDSA: init at 1.17
perlPackages.CryptRIPEMD160: init at 0.06
perlPackages.CryptTwofish: init at 2.17
perlPackages.DataBuffer: init at 0.04
perlPackages.DigestMD2: init at 2.04
perlPackages.MathPrimeUtil: init at 0.73
perlPackages.MathPrimeUtilGMP: init at 0.52
perlPackages.TieEncryptedHash: init at 1.24
@stigtsp stigtsp force-pushed the package/perl-crypt-openpgp-init branch from 375559e to e68e4ca Compare July 24, 2020 14:13
@stigtsp
Copy link
Member Author

stigtsp commented Jul 24, 2020 •
edited

I've had a look at cpantesters.org, and 9 out of 687 failed the 'serialized public key_id matches secret key_id' test.

https://www.cpantesters.org/cpan/report/7a35d05c-898a-11e5-9891-796e02dd8615
https://www.cpantesters.org/cpan/report/7e6b66f0-a6d1-11e5-85ab-3f9d8200d99d
https://www.cpantesters.org/cpan/report/91c4c0a2-0ae5-11e6-829f-59a5aef69d38
https://www.cpantesters.org/cpan/report/2462e13a-76d7-11e5-8ae4-893dcfe82091
https://www.cpantesters.org/cpan/report/24059160-7696-11e5-8ae4-893dcfe82091
https://www.cpantesters.org/cpan/report/a015185e-be36-11e7-9d0d-0732b2fc9795
https://www.cpantesters.org/cpan/report/b959b60b-7c3f-1014-ad9e-139594f39f87
https://www.cpantesters.org/cpan/report/d0013826-0271-11e7-a074-e1beba07c9dd
https://www.cpantesters.org/cpan/report/e8cbc196-4f61-11e6-a1f7-bae35bc2a771

It would need some more investigation, but I speculate that it could be an encoding issue when the test is comparing the binary values. Running the test 4713 times resulted in 6 failures.

From t/13-keygen.t

    # line 29
    is $pub->key->key_id, $sec->key->key_id,
        'public key_id matches secret key_id';

   # line 50
   is $pieces[0]->key_id, $sec->key->key_id,
        'serialized public key_id matches secret key_id';

I've added a patch that removes these two tests.

@stigtsp stigtsp marked this pull request as ready for review July 24, 2020 14:15
@stigtsp
Copy link
Member Author

stigtsp commented Jul 24, 2020

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

1 similar comment
@aanderse
Copy link
Member

@GrahamcOfBorg build perlPackages.CryptOpenPGP perldevelPackages.CryptOpenPGP

@aanderse
Copy link
Member

@stigtsp merge?

@stigtsp
Copy link
Member Author

stigtsp commented Jul 26, 2020

@stigtsp merge?

Yes pls :)

@aanderse aanderse merged commit 970b2b8 into NixOS:master Jul 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aanderse aanderse Awaiting requested review from aanderse

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @aanderse