Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/manual: add a section about Vulkan drivers #93591

Merged
merged 1 commit into from Jul 22, 2020
Merged

nixos/manual: add a section about Vulkan drivers #93591

merged 1 commit into from Jul 22, 2020

Conversation

Flakebi
Copy link
Member

@Flakebi Flakebi commented Jul 21, 2020

  • Add a general block about how to configure and test Vulkan
  • Add a section about switching between mesa/radv and amdvlk on AMD
    GPUs.
Motivation for this change

Add documentation is wanted in #82305. The text took a lot of inspiration from #93290.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk, @acowley

@Flakebi Flakebi requested review from danieldk and acowley July 21, 2020 12:24
danieldk
danieldk suggested changes Jul 21, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! It is really nice to have this documented.

I added two very small suggested changes.

nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
nixos/doc/manual/configuration/gpu-accel.xml Outdated Show resolved Hide resolved
@Flakebi
nixos/manual: add a section about Vulkan drivers
350f1d6 
- Add a general block about how to configure and test Vulkan
- Add a section about switching between mesa/radv and amdvlk on AMD
  GPUs.
@danieldk danieldk merged commit 5226e6b into NixOS:master Jul 22, 2020
@Flakebi Flakebi deleted the vulkan-manual branch July 22, 2020 15:03
@Flakebi
Copy link
Member Author

Flakebi commented Jul 22, 2020

Thank you all for reviewing and merging it so quickly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@danieldk danieldk danieldk approved these changes

@acowley acowley acowley approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: documentation 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Flakebi @danieldk @acowley @jonringer