Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resilio-sync: 2.7.1 -> 2.7.2 #93630

Merged
merged 1 commit into from Jul 31, 2020
Merged

resilio-sync: 2.7.1 -> 2.7.2 #93630

merged 1 commit into from Jul 31, 2020

Conversation

danieldk
Copy link
Contributor

Motivation for this change

Changelog:

https://help.resilio.com/hc/en-us/articles/206216855-Sync-2-x-change-log

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk danieldk changed the title resilio-sync: 2.7.1 -> 2.7.1 resilio-sync: 2.7.1 -> 2.7.2 Jul 23, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/237

@jonringer
Copy link
Contributor

@GrahamcOfBorg eval
@GrahamcOfBorg build pkgsi686Linux.resilio-sync
@GrahamcOfBorg build resilio-sync

jonringer
jonringer approved these changes Jul 31, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

diff LGTM
both arch version built for me
shows usage

https://github.com/NixOS/nixpkgs/pull/93630
1 package built:
resilio-sync

@jonringer jonringer merged commit 4d19709 into NixOS:master Jul 31, 2020
@danieldk danieldk deleted the resilio-sync-2.7.2 branch July 31, 2020 17:53
@danieldk
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@cwoac cwoac Awaiting requested review from cwoac

@domenkozar domenkozar Awaiting requested review from domenkozar

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @jonringer