Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kernelPackages.r8168: 8.047.04 -> 8.048.03 #93620

Merged
merged 1 commit into from Nov 5, 2020
Merged

kernelPackages.r8168: 8.047.04 -> 8.048.03 #93620

merged 1 commit into from Nov 5, 2020

Conversation

lovesegfault
Copy link
Member

Motivation for this change

I tried to use this and it was broken.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lovesegfault lovesegfault requested review from globin and timokau and removed request for globin July 22, 2020 04:05
@timokau
Copy link
Member

timokau commented Jul 22, 2020

I was aware that it was broken with newer versions, but I didn't know that a fix is available now. Thanks!

Anyway, when the breakage occurred that made me try the in-tree driver again. Its good enough for my purposes now, so I don't use r8168 anymore. Would you mind removing me from the maintainers list?

@timokau timokau mentioned this pull request Oct 28, 2020
Closed
vikanezrimaya
vikanezrimaya approved these changes Nov 5, 2020
View reviewed changes
Copy link
Member

@vikanezrimaya vikanezrimaya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built successfully and generally LGTM - sadly the hardware I could use to test this is not available right now. I wonder why is this not merged yet?

@timokau
Copy link
Member

timokau commented Nov 5, 2020

Thanks for the reminder.

I wonder why is this not merged yet?

I didn't merge this originally because of my maintainers-request. Lacking any feedback there, that isn't any reason to keep this PR up any longer though. I can do that myself some other time.

@timokau timokau merged commit 16e34d2 into NixOS:master Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

@timokau timokau Awaiting requested review from timokau

@globin globin Awaiting requested review from globin

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lovesegfault @timokau @vikanezrimaya