Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

R: remove qtbase.patch and fix few CRAN packages #93590

Merged
merged 1 commit into from Jan 18, 2021
Merged

R: remove qtbase.patch and fix few CRAN packages #93590

merged 1 commit into from Jan 18, 2021

Conversation

lblasc
Copy link
Contributor

@lblasc lblasc commented Jul 21, 2020 •
edited

Motivation for this change

Last R package update removed prophet which is again available with this update. I've also updated bioc-annotation-packages.nix and bioc-experiment-packages.nix.

Remove qtbase.patch which is leftover from last update and fix few CRAN packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lblasc lblasc requested a review from peti as a code owner July 21, 2020 12:04
@peti
Copy link
Member

peti commented Jul 21, 2020

Test builds are running at https://hydra.nixos.org/jobset/nixpkgs/r-updates ...

@lblasc
Copy link
Contributor Author

lblasc commented Jul 21, 2020

@peti can you please do another test build? openssl had broken configure script.

@lblasc lblasc changed the title R: Update CRAN and bioconductor packages R: 4.0.0 -> 4.0.2, update CRAN and bioconductor packages Jul 26, 2020
@lblasc
Copy link
Contributor Author

lblasc commented Jul 26, 2020

rebased, I also bumped R to 4.0.2. Should be ready for merge.

@ofborg ofborg bot requested a review from timokau July 26, 2020 09:24
@lblasc
Copy link
Contributor Author

lblasc commented Aug 10, 2020

@peti anything else needed ? thx!

@lblasc lblasc changed the title R: 4.0.0 -> 4.0.2, update CRAN and bioconductor packages R: update CRAN and bioconductor packages Sep 24, 2020
@lblasc lblasc mentioned this pull request Oct 14, 2020
Merged
10 tasks
@moritzschaefer
Copy link
Contributor

moritzschaefer commented Oct 23, 2020 •
edited

While R 4.0.2 and updated bioconductor already made it into master, the patch for openssl didn't.

@lblasc, I created a PR for this fix and linked you to it. Maybe we can close this PR and if you have time, you could test the other one?

@moritzschaefer moritzschaefer mentioned this pull request Oct 23, 2020
Merged
10 tasks
@lblasc lblasc changed the title R: update CRAN and bioconductor packages R: remove qtbase.patch and fix few CRAN packages Nov 5, 2020
@SuperSandro2000
Copy link
Member

@peti friendly ping

@peti peti merged commit a15e4b6 into NixOS:master Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

@timokau timokau Awaiting requested review from timokau

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lblasc @peti @moritzschaefer @SuperSandro2000