buildGoModule: allow modSha256 #93624
Conversation
|
I don't have strong feelings either way tbh. This is an acceptable change as far as I am concerned. |
|
cc @c00w |
|
So this is basically the opposite of #93513 |
We should see about getting a @NixOS/golang
Yeah. I want to get rid of |
|
With 20.09 getting closing this will at least buy us another few months to find a reliable solution. |
There was a problem hiding this comment.
I think this is completely ridiculous.
@zowoq is the entire reason we haven't been able to merge runVend, so him claiming we're in some sort of helpless situation here seems extremely duplicitious.
Additionally, it's generally doable to fix specific issues with the vendor folder (as this code shows), in a fairly straightforward way, so I don't understand what benefit we get by undoing the go vendor work.
|
I would be actually in favor of having vendoring to work with @c00w solution rather than having to maintain to different module implementation. |
ofborg
bot
added
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
and removed
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
labels
ofborg
bot
added
8.has: package (new)
10.rebuild-darwin: 1-10
10.rebuild-linux: 1-10
and removed
10.rebuild-darwin: 101-500
10.rebuild-linux: 101-500
labels
|
Updated this to use https://github.com/goware/modvendor. The vendor command is a bit long but it seems to work. |
| @@ -21,6 +21,8 @@ | |||
| # Whether to delete the vendor folder supplied with the source. | |||
| , deleteVendor ? false | |||
|
|
|||
| , modvendorCopy ? false | |||
There was a problem hiding this comment.
Can you mention this in doc/languages-frameworks/go.xml?
|
What is the difference between this and |
I'll add something to the docs if we decide to go with this PR.
It's a simpler tool. It doesn't wrap Downside is that it is a simple tool and we need to tell it to what to copy. Also, if we ever need to add more file types for whatever reason we may end up having to fix hashes because if those new file types exist in current packages they weren't being copied. I'm not sure if this is better approach than |
Having an explicit list does not sounds like a good idea. However I am concerned that if we ever add any file to the whitelist, we might break hashes. Would it be a bad idea to just add everything? |
We can add as many file types as we want but anything else would require patching. |
I'm not really happy about proposing this but I think we need some way of reliably dealing with these cases when
go mod vendordoesn't work that doesn't require manual intervention.Allowing the use of the previous implementation as a last resort seems the easiest approach.
cc @kalbasit @marsam @Mic92