Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

faac/faad2: other homepage #93626

Merged
merged 1 commit into from Aug 16, 2020
Merged

faac/faad2: other homepage #93626

merged 1 commit into from Aug 16, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Jul 22, 2020

Because it seems the audiocoding.com domain expired

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@raboof raboof changed the title Other homepage for libfaac and libfaad2 faac/faad2: other homepage Jul 22, 2020
@veprbl veprbl requested a review from codyopel July 23, 2020 00:11
@raboof
Copy link
Member Author

raboof commented Jul 31, 2020

/marvin opt-in

@marvin-mk2
Copy link

marvin-mk2 bot commented Jul 31, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

@marvin-mk2 marvin-mk2 bot added the marvin label Jul 31, 2020
@alyssais
Copy link
Member

I don’t think Wikipedia can really count as a homepage. If there’s no homepage any more, just delete the line.

@raboof
libfaac/libfaad2: drop homepage
1d20613 
Because it seems the audiocoding.com domain expired
@raboof raboof force-pushed the different-link-for-faac-and-libfaad2 branch from be11f26 to 1d20613 Compare August 16, 2020 11:33
@raboof
Copy link
Member Author

raboof commented Aug 16, 2020

If there’s no homepage any more, just delete the line.

Ah, didn't realize it was optional 👍, updated

@alyssais alyssais merged commit cde92f9 into NixOS:master Aug 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codyopel codyopel Awaiting requested review from codyopel

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0 marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raboof @alyssais