Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blockbook: fix build on aarch64-linux #93610

Merged
merged 1 commit into from Jul 22, 2020
Merged

blockbook: fix build on aarch64-linux #93610

merged 1 commit into from Jul 22, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Jul 21, 2020

Motivation for this change

This PR fixes the build failure on aarch64-linux. For some reason the aarch64 build does not seem to be able to find the latest libstdc++, so we help a little with adding -L${stdenv.cc.cc.lib}/lib explicitly to the CGO_LDFLAGS.

Plus I cleaned up the package a little bit

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak requested review from 1000101 and mmahut July 21, 2020 20:23
@prusnak
Copy link
Member Author

prusnak commented Jul 21, 2020

@GrahamcOfBorg build blockbook

@ofborg ofborg bot requested a review from kalbasit July 22, 2020 00:41
1000101
1000101 approved these changes Jul 22, 2020
View reviewed changes
Copy link
Member

@1000101 1000101 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!!!

  • reviewed the diff and commit messages
  • made sure ofBorg build succeeded for all applicable platforms
  • ran nix-review without any failures
  • ran and tested the binaries (x86_64-linux only)

@mmahut mmahut merged commit b8c367a into NixOS:master Jul 22, 2020
@prusnak prusnak deleted the blockbook branch July 22, 2020 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1000101 1000101 1000101 approved these changes

@mmahut mmahut Awaiting requested review from mmahut

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @1000101 @mmahut