Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oneDNN: 1.5 -> 1.5.1 #93623

Merged
merged 3 commits into from Jul 23, 2020
Merged

oneDNN: 1.5 -> 1.5.1 #93623

merged 3 commits into from Jul 23, 2020

Conversation

marsam
Copy link
Contributor

@marsam marsam commented Jul 22, 2020

Motivation for this change

also fixes #93127 cc: @mstone

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from alexarice and bhipple July 22, 2020 04:52
drewrisinger
drewrisinger suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@drewrisinger drewrisinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Diff LGTM
  • Commits could be squashed together into just the upgrade commit
  • Builds via nix-review: built everything up to (not including) pytorch, the build was taking too long so I had to cancel.

@marsam marsam merged commit bd0eb11 into NixOS:master Jul 23, 2020
@marsam marsam deleted the enable-oneDNN-darwin branch July 23, 2020 01:20
@bhipple
Copy link
Contributor

bhipple commented Jul 23, 2020

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@drewrisinger drewrisinger drewrisinger requested changes

@alexarice alexarice Awaiting requested review from alexarice

@bhipple bhipple Awaiting requested review from bhipple

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add darwin support for oneDNN
3 participants
@marsam @bhipple @drewrisinger