Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

newsflash: init at 1.0.1 #93622

Merged
merged 1 commit into from Jul 22, 2020
Merged

newsflash: init at 1.0.1 #93622

merged 1 commit into from Jul 22, 2020

Conversation

kira-bruneau
Copy link
Contributor

@kira-bruneau kira-bruneau commented Jul 22, 2020 •
edited

Motivation for this change

Adds NewsFlash. A modern feed reader designed for the GNOME desktop, and the spiritual successor to FeedReader.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@kira-bruneau kira-bruneau force-pushed the newsflash branch 2 times, most recently from 0bc4c69 to e36ce2d Compare July 22, 2020 04:26
@dasj19
Copy link
Contributor

dasj19 commented Jul 22, 2020

I tested with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 93622" and it builds fine. However I could not find an executable to run.

@kira-bruneau
Copy link
Contributor Author

@dasj19 The executable is named com.gitlab.newsflash

@kira-bruneau
Copy link
Contributor Author

@danieldk I've opened an issue asking upstream to add the lock file: https://gitlab.com/news-flash/news_flash_gtk/-/issues/112.

@dasj19
Copy link
Contributor

dasj19 commented Jul 22, 2020

@dasj19 The executable is named com.gitlab.newsflash

Yes, that works fine... You can thick the 3rd checkbox in the description ("Tested compilation of all pkgs that depend on this change using...")

danieldk
danieldk approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93622 1

1 package built:
- newsflash

I took the liberty to run nixpkgs-fmt on the derivation to standardize formatting of the argument attrset a bit.

@danieldk danieldk merged commit 99afbad into NixOS:master Jul 22, 2020
@kira-bruneau
Copy link
Contributor Author

@danieldk Thanks! I didn't know about nixpkgs-fmt, but I will use it in all my commits now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kira-bruneau @dasj19 @danieldk