Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

postgrest: 7.0.0 -> 7.0.1 #93632

Closed
wants to merge 1 commit into from
Closed

postgrest: 7.0.0 -> 7.0.1 #93632

wants to merge 1 commit into from

Conversation

danielstaleiny
Copy link
Contributor

  • change dependency protolude to depend on 0.3.0
  • change configurator-pg dependency for protolude to depend on 0.3.0 as well
Motivation for this change

To get latest version of Postgrest which is 7.0.1
hackage postgrest

Things done

Bump version of postgrest to 7.0.1

  • change dependency protolude to depend on 0.3.0
  • change configurator-pg dependency for protolude to depend on 0.3.0 as well

configurator-pg needs to have same protolude, so I had to bump version for it as well.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danielstaleiny danielstaleiny changed the title Bump version of postgrest to 7.0.1 postgrest: 7.0.0 -> 7.0.1 Jul 22, 2020
cdepillabout
cdepillabout reviewed Jul 22, 2020
View reviewed changes
pkgs/development/haskell-modules/configuration-hackage2nix.yaml Outdated
@@ -1720,7 +1720,7 @@ default-package-overrides:
- postgresql-libpq ==0.9.4.2
- postgresql-orm ==0.5.1
- postgresql-simple ==0.6.2
- postgrest ==7.0.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list is package versions from the latest stackage LTS, they are (semi-?)automatically updated. We don't change them by hand. I imagine the next version of stackage will bump postgrest to 7.0.1, so we can just wait for that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know that, thank you. but the rest should be updated like I did ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, no, I think everything else in this PR should happen automatically as well, so I think you can go ahead and close this.

Check out #92461 over the next couple days.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh, alright. thanks for the info and sorry for wasting your time. among my first PR.

@danielstaleiny
Bump version of postgrest to 7.0.1
8149256 
- change dependency protolude to depend on 0.3.0
- change configurator-pg dependency for protolude to depend on 0.3.0 as well
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout cdepillabout left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danielstaleiny @cdepillabout