Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocsigen_server: fix build; 2.15.0 → 2.16.0 #93612

Merged
merged 2 commits into from Jul 26, 2020
Merged

ocamlPackages.ocsigen_server: fix build; 2.15.0 → 2.16.0 #93612

merged 2 commits into from Jul 26, 2020

Conversation

sternenseemann
Copy link
Member

@sternenseemann sternenseemann commented Jul 21, 2020 •
edited

Motivation for this change

Fix current build failure; lwt 5.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@sternenseemann
ocamlPackages.ocsigen_server: 2.15.0 → 2.16.0
d21435e 
Also increase lower OCaml version bound to 4.06.1. Note that this
increase has not been introduced in 2.16.0, but has been like this since
2.11.0.
@sternenseemann sternenseemann changed the title ocamlPackages.ocsigen_server: fix compilation ocamlPackages.ocsigen_server: fix build; 2.15.0 → 2.16.0 Jul 22, 2020
@sternenseemann
Copy link
Member Author

@GrahamcOfBorg build ocamlPackages.eliom ocamlPackages.ocsigen-start ocamlPackages.ocsigen-toolkit ocamlPackages.ocsigen_server

@sternenseemann sternenseemann requested a review from vbgl July 25, 2020 07:53
@sternenseemann sternenseemann mentioned this pull request Jul 25, 2020
Merged
10 tasks
@vbgl
Copy link
Contributor

vbgl commented Jul 25, 2020

The current build failure does not seem related to lwt 5: bisection leads to an update of gnumake (0cfe9f3).

@sternenseemann
Copy link
Member Author

Yeah, sorry I it's not worded clearly:

  • The build fix is just the patch added in a3a85f7 (also applies on 2.15.0)*
  • 2.16.0 is supposed to increase compatibility with lwt 5 according to ocsigen_server's change log

@vbgl
Copy link
Contributor

vbgl commented Jul 26, 2020

@GrahamcOfBorg build ocamlPackages.ocsigen-start

@vbgl
Copy link
Contributor

vbgl commented Jul 26, 2020

Thanks for the clarification (and for the good PR)!

@vbgl vbgl merged commit 6a565f2 into NixOS:master Jul 26, 2020
@sternenseemann sternenseemann deleted the ocsigen_server-fix branch July 26, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FlorentBecker FlorentBecker Awaiting requested review from FlorentBecker

@vbgl vbgl Awaiting requested review from vbgl

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sternenseemann @vbgl