Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openhantek6022: init at 3.1.1 #93613

Merged
merged 1 commit into from Aug 11, 2020
Merged

openhantek6022: init at 3.1.1 #93613

merged 1 commit into from Aug 11, 2020

Conversation

baracoder
Copy link
Contributor

@baracoder baracoder commented Jul 21, 2020 •
edited

Motivation for this change

Adding this package for a cheap USB oscilloscope I bought recently.

On NixOS, the package can be added to services.udev.packages to set up udev rules.
TAG+="uaccess", TAG+="udev-acl" did not do the trick. I have added GROUP="plugdev", MODE="0666"

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that evaluation fails. Also added some comments.

pkgs/applications/science/electronics/openhantek6022/udev-rules.patch Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/cmake-paths.patch Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/default.nix Outdated Show resolved Hide resolved
pkgs/applications/science/electronics/openhantek6022/default.nix Outdated Show resolved Hide resolved
@baracoder
Copy link
Contributor Author

Note that evaluation fails. Also added some comments.

Not sure why the evaluation check fails, I can build and install it on my machine 🙈

@baracoder baracoder marked this pull request as draft July 22, 2020 21:55
@baracoder baracoder force-pushed the init-openhantek6022 branch 2 times, most recently from e32258b to 5556c9f Compare July 23, 2020 22:40
@baracoder
Copy link
Contributor Author

@danieldk thank you for the review and suggestions. I am still not sure why the checks fail. I have run the commands on mentioned on NixOS/ofborg and did not complain. Can you point me where to look for the problem?

@danieldk
Copy link
Contributor

danieldk commented Jul 24, 2020 •
edited

Can you point me where to look for the problem?

libusb is an alias for libusb1 and the use of aliases is not permitted. So if you replace each occurrence of libusb in your derivation by libusb1, that should fix it.

@baracoder
Copy link
Contributor Author

I think I finally get it:
The first check grahamcofborg-eval
Is the parent for grahamcofborg-eval-package-list-no-aliases, which failed, and that failed because

nix-env -qa --json --file . --arg config { allowAliases = false; }

hides aliasses, which results in

... openhantek6022/default.nix:1:1 called without required argument 'libusb' ...

@baracoder baracoder marked this pull request as ready for review July 29, 2020 20:31
danieldk
danieldk approved these changes Jul 30, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 93613 1

1 package built:
  • openhantek6022

But it would be nice if someone else could also review this. I am currently on the go and cannot test GUI applications.

@danieldk danieldk merged commit 01a6953 into NixOS:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@baracoder @danieldk