Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

restinio: init at 0.6.8.1 #94460

Closed
wants to merge 1 commit into from
Closed

restinio: init at 0.6.8.1 #94460

wants to merge 1 commit into from

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented Aug 1, 2020 •
edited

Motivation for this change

In my quest to package Jami, also requested at #83411 I learned that this is a dependency of several components of the project.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

dasj19
dasj19 reviewed Aug 2, 2020
View reviewed changes
Copy link
Contributor

@dasj19 dasj19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds well with nix-shell -p nixpkgs-review --run "nixpkgs-review pr 94460". I don't know how to make use of this library though...

@doronbehar
Copy link
Contributor Author

Thanks for testing, but now I noticed I forgot to commit the all-packages.nix line addition, which means nixpkgs-review probably hasn't built anything for you :/.

@doronbehar doronbehar mentioned this pull request Aug 2, 2020
Closed
@doronbehar
Copy link
Contributor Author

The last push is an attempt to make the build succeed on Darwin, not like the latest: https://github.com/NixOS/nixpkgs/pull/94460/checks?check_run_id=937777778

@doronbehar
Copy link
Contributor Author

Can't fix the Darwin build, marking it as broken for Darwin.

@bqv
Copy link
Contributor

bqv commented Nov 10, 2020

Maybe opt in marvin?

@doronbehar
Copy link
Contributor Author

Maybe opt in marvin?

TBH I'm not prioritizing this, as I didn't manage to eventually get jami working with this package, it may be worth testing again now.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 94460 run on x86_64-linux 1

1 package built:
  • restinio

@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 24, 2020 •
edited

Result of nixpkgs-review pr 94460 run on x86_64-darwin 1

1 package marked as broken and skipped:
  • restinio

image

96% tests passed, 1 tests failed out of 27

Total Test time (real) =   0.16 sec

The following tests FAILED:
         13 - _unit.test.start_stop (Failed)
Errors while running CTest
make: *** [Makefile:149: test] Error 8
builder for '/nix/store/6shn01fhjkksvdhgvm6wvp8vipp3x3f2-restinio-0.6.8.1.drv' failed with exit code 2
error: build of '/nix/store/6shn01fhjkksvdhgvm6wvp8vipp3x3f2-restinio-0.6.8.1.drv' failed

@doronbehar
Copy link
Contributor Author

I will not attempt to package jami in the near future, so this PR has no use. Of course anyone is free to pick up the work I did here and / or in https://github.com/doronbehar/nixpkgs/blob/package-jami-dirty/pkgs/applications/networking/instant-messengers/jami/default.nix (branch package-jami-dirty).

@doronbehar doronbehar closed this Nov 25, 2020
@bqv
Copy link
Contributor

bqv commented Nov 25, 2020

I have been using guix for jami instead, quite successfully.

@doronbehar doronbehar deleted the package-jami branch March 2, 2023 10:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasj19 dasj19 dasj19 left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@doronbehar @bqv @SuperSandro2000 @dasj19