New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mfcj835dwlpr: init at 3.0.1-1, mfcj835dw-cupswrapper: init at 3.0.0-1 #94461
Conversation
|
||
buildPhase = '' | ||
cd brcupsconfig | ||
make all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please do not overwrite buildPhase but use preBuild, postBuild and Makeflags.
##TODO: Use the cups filter instead of the LPR one. | ||
#cp scripts/cupswrappermfcj835dw $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw | ||
#sed -i -e '110,258!d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw | ||
#sed -i -e '33,40d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw | ||
#sed -i -e '34,35d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw | ||
#substituteInPlace $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw \ | ||
# --replace "/opt/brother/$``{device_model``}/$``{printer_model``}/lpd/filter$``{printer_model``}" \ | ||
# "${mfcj835dwlpr}/opt/brother/Printers/mfcj835dw/lpd/filtermfcj835dw" \ | ||
# --replace "/opt/brother/Printers/$``{printer_model``}/inf/br$``{printer_model``}rc" \ | ||
# "${mfcj835dwlpr}/opt/brother/Printers/mfcj835dw/inf/brmfcj835dwrc" \ | ||
# --replace "/opt/brother/$``{device_model``}/$``{printer_model``}/cupswrapper/brcupsconfpt1" \ | ||
# "$out/opt/brother/Printers/mfcj835dw/cupswrapper/brcupsconfpt1" \ | ||
# --replace "/usr/share/cups/model/Brother/brother_" "$out/opt/brother/Printers/mfcj835dw/cupswrapper/brother_" | ||
#substituteInPlace $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw \ | ||
# --replace "$``{printer_model``}" "mfcj835dw" \ | ||
# --replace "$``{printer_name``}" "MFCJ835DW" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer removing this.
make clean | ||
''; | ||
|
||
meta = with stdenv.lib; { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
meta = with stdenv.lib; { | |
meta = with lib; { |
|
||
cleanPhase = '' | ||
cd brcupsconfpt1 | ||
make clean | ||
''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cleanPhase = '' | |
cd brcupsconfpt1 | |
make clean | |
''; |
meta = with stdenv.lib; { | ||
homepage = http://www.brother.com/; | ||
description = "Brother MFC-J835DW CUPS wrapper driver"; | ||
license = with licenses; gpl2; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Plus or Only?
I marked this as stale due to inactivity. → More info |
I would like to close this pull request since it is no longer relevant to me. I have since moved to another printer, and don't have the time to test the package on a printer I won't be using. |
Motivation for this change
Add the drivers and cups wrappers for the Brother MFCJ835DW printer.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)