Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfcj835dwlpr: init at 3.0.1-1, mfcj835dw-cupswrapper: init at 3.0.0-1 #94461

Closed
wants to merge 6 commits into from

Conversation

alexander-c-b
Copy link

@alexander-c-b alexander-c-b commented Aug 1, 2020

Motivation for this change

Add the drivers and cups wrappers for the Brother MFCJ835DW printer.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@alexander-c-b alexander-c-b marked this pull request as ready for review August 1, 2020 17:26
@alexander-c-b alexander-c-b changed the title Mfcj835dw mfcj835dwlpr: init at 3.0.1-1, mfcj835dw-cupswrapper: init at 3.0.0-1 Aug 1, 2020

buildPhase = ''
cd brcupsconfig
make all
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not overwrite buildPhase but use preBuild, postBuild and Makeflags.

Comment on lines +34 to +49
##TODO: Use the cups filter instead of the LPR one.
#cp scripts/cupswrappermfcj835dw $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw
#sed -i -e '110,258!d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw
#sed -i -e '33,40d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw
#sed -i -e '34,35d' $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw
#substituteInPlace $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw \
# --replace "/opt/brother/$``{device_model``}/$``{printer_model``}/lpd/filter$``{printer_model``}" \
# "${mfcj835dwlpr}/opt/brother/Printers/mfcj835dw/lpd/filtermfcj835dw" \
# --replace "/opt/brother/Printers/$``{printer_model``}/inf/br$``{printer_model``}rc" \
# "${mfcj835dwlpr}/opt/brother/Printers/mfcj835dw/inf/brmfcj835dwrc" \
# --replace "/opt/brother/$``{device_model``}/$``{printer_model``}/cupswrapper/brcupsconfpt1" \
# "$out/opt/brother/Printers/mfcj835dw/cupswrapper/brcupsconfpt1" \
# --replace "/usr/share/cups/model/Brother/brother_" "$out/opt/brother/Printers/mfcj835dw/cupswrapper/brother_"
#substituteInPlace $CPUSFILTERFOLDER/brother_lpdwrapper_mfcj835dw \
# --replace "$``{printer_model``}" "mfcj835dw" \
# --replace "$``{printer_name``}" "MFCJ835DW"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer removing this.

make clean
'';

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

Comment on lines +51 to +55

cleanPhase = ''
cd brcupsconfpt1
make clean
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
cleanPhase = ''
cd brcupsconfpt1
make clean
'';

meta = with stdenv.lib; {
homepage = http://www.brother.com/;
description = "Brother MFC-J835DW CUPS wrapper driver";
license = with licenses; gpl2;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Plus or Only?

@stale
Copy link

stale bot commented Jul 21, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jul 21, 2021
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 14, 2021
@alexander-c-b
Copy link
Author

I would like to close this pull request since it is no longer relevant to me. I have since moved to another printer, and don't have the time to test the package on a printer I won't be using.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants