Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

navi: init at 2.7.1 #94469

Merged
merged 2 commits into from Aug 4, 2020
Merged

navi: init at 2.7.1 #94469

merged 2 commits into from Aug 4, 2020

Conversation

cust0dian-old
Copy link
Contributor

Motivation for this change

navi allows you to browse through cheatsheets (that you may write yourself or download from maintainers) and execute commands. Argument suggestions are prompted to you.

https://github.com/denisidoro/navi

Closes #82476 (previous attempt at packaging it) since it seems to have stagnated.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

danieldk
danieldk suggested changes Aug 4, 2020
View reviewed changes
pkgs/applications/misc/navi/default.nix

nativeBuildInputs = [ makeWrapper ];

postInstall = ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream also provides shell completion files:

https://github.com/denisidoro/navi/tree/master/shell

You install install them using installShellCompletion after putting installShellFiles in nativeBuildInputs.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are not really completions, they are adding key binding for navi widget, and upstream recommends opting into it via invoking subcommand in your rc file — would we want to implicitly set it up for users?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, sorry for the noise. No, I don't think we should set them up implicitly.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, thank you for review!

danieldk
danieldk approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 94469 1

1 package built:
  • navi

The program seems to work as expected. Thanks a lot for contributing this!

@danieldk danieldk merged commit b56eb10 into NixOS:master Aug 4, 2020
@cust0dian-old cust0dian-old deleted the navi-2.7.1 branch August 4, 2020 10:23
@cust0dian-old cust0dian-old mentioned this pull request Aug 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cust0dian-old @danieldk @cust0dian